[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [hobbit] overflow in netbsd-meminfo.c
- To: hobbit (at) hswn.dk
- Subject: Re: [hobbit] overflow in netbsd-meminfo.c
- From: "Tracy Di Marco White" <gendalia (at) iastate.edu>
- Date: Thu, 13 Nov 2008 10:06:23 -0600
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=LRmto7zb4+ER2Soca4GWQ8oKj78Rv4ZFe2zVh39gwpw=; b=F8omNhTvyK1QaHPSczz2d8x82XTXvhHtg/MzhseQof//DbjIH6QmByL4SoiPOehOLo EpqI1Lny2nWa1Kz5OZrwiEHRt3HwDmVZKXjQibPto2sui1sng3id6MEBog8brP4Yd/fM drQfL8SVoblQHuoaSLrzfpYLxr/FogxqFsmtA=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=IW2EdiFdUYSDrf4tf+eCx+AT98IN37W+v47295T9Sa028uDPagJfQMlRDltYB6go1k ud0nHF0k7L1Du4pFF2OQDZXBHu7JfriOHH/HQ3QOadUKEcC4NT+cjv1m9gROE6gZFlll EmyfmN4qZAdIuZg2ANEHg2VszZUcyR8Y8wgOY=
- References: <2193.1226548301 (at) satai.its.iastate.edu> <491BA7B9.8000806 (at) wi.rr.com> <7024c8c80811122027s2c0f8916uaa9b6e4cd1d45c02 (at) mail.gmail.com> <491BB067.9040609 (at) wi.rr.com> <7024c8c80811122109y555e995fxe4f9bd609f991878 (at) mail.gmail.com> <491C0E91.6090701 (at) wi.rr.com> <7024c8c80811130617w2bb4e7e7la66eab1400f10a30 (at) mail.gmail.com> <491C40E4.1080407 (at) wi.rr.com>
On Thu, Nov 13, 2008 at 8:59 AM, Rich Smrcina <rsmrcina (at) wi.rr.com> wrote:
> Tracy Di Marco White wrote:
>>
>> On Thu, Nov 13, 2008 at 5:25 AM, Rich Smrcina <rsmrcina (at) wi.rr.com> wrote:
>>>
>>> You posted this last night:
>>>
>>> Memory Used Total Percentage
>>> Physical 4294963639M 4294966523M 0%
>>> Swap 0M 4098M 0%
>>
>> I said that was from hobbit, not from NetBSD. It's from the hobbit
>> display page which I assume is generated from the "client data"
>> information it has received, which is why I later included the
>> "meminfo" information from the client data, which is generated by the
>> hobbit client. The only thing directly generated by NetBSD that I've
>> included was the "sysctl -a|grep physmem" information.
>
> <egg-on-face>
> Ugh! My apologies, Tracy. For some reason, I thought that was from NetBSD.
> I guess I should read slower... :)
> </egg-on-face>
No problem, I just wasn't sure of what was wrong when I sent that.
Your mail made me search harder to make sure I understood what was
going on, which isn't a bad thing. And comparing to FreeBSD's helped
too.
In freebsd-meminfo.c, pagesize is an unsigned long also (as is
physmem). I don't expect pagesize on NetBSD to be more than max int
any time soon, but should I also change that in netbsd-meminfo.c,
where it's also an int?
(I'm planning to include this patch in the pkgsrc hobbitclient update
I'm going to do as soon as I'm relatively sure this is mostly correct.
It would also be nice to have integrated for some future release of
hobbit/xymon as well.)
-Tracy