[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [hobbit] Preparing a 4.2.1 release

Henrik Størner <mailto:henrik (at) hswn.dk> wrote:
> I'm preparing an official 4.2.1 release (should perhaps call it
> 4.2.2). This is for two reasons:
> 
> 1) To put the all-in-one patch into an official release,
>    which is apparently necessary.
> 2) To do a preliminary renaming from Hobbit to Xymon.
> 
> 1) is obvious, and 2) is only for documentation and web-
> template changes. No new stuff.
> 
> Except one new thing: The BBWin patch to allow the BBWin
> centralized config mode - I think this is important enough
> that it should go in now, since there are probably quite a
> few people who will want this in their setup.
> 
> Anything else ? New feature stuff will not be accepted, this
> is purely a maintenance version until 4.3/5.0 arrives.
> 
> 
> Henrik

Hi Henrik,

The attached patch (pingloop.patch) was, I think, applied by you to trunk in
May, but the same issue is in 4.2.0 (and I've had it since on a 4.2.0
server).

Kind regards,

SebA
--- Begin Message --- 
On Thu, May 22, 2008 at 07:07:42PM +0100, Sebastian wrote:
> I rebooted my hobbit server and it lost its default gateway, unbeknown to
> me.  The only symptoms of something wrong was a purple in a network test
is
> was supposed to be doing and a purple in the server's bbtest column.  Now,
I
> reckon one or other or both of these should have both gone red and not
> purple, and the reason that they did not is due to hobbitping going into a
> spin:  what looks like a fairly tight loop.  Hobbitping was using quite a
> lot of CPU (I saw it at well over 30%) and server/tmp/ping-stdout.1407 was
> empty but server/tmp/ping-stderr.5499 was getting many (about 60) "Failed
to
> send ICMP packet: Network is unreachable" written to it every second.

Thanks, the attached patch should solve this problem.


Regards,
Henrik


--- hobbit/bbnet/hobbitping.c	2008/01/03 09:42:11	1.14
+++ hobbit/bbnet/hobbitping.c	2008/05/23 08:47:33
@@ -211,7 +211,10 @@
 			   (struct sockaddr *) &hosts[idx]->addr, sizeof(struct sockaddr_in));
 
 	if (sentbytes == -1) {
-		if (errno != EWOULDBLOCK) errprintf("Failed to send ICMP packet: %s\n", strerror(errno));
+		if (errno != EWOULDBLOCK) {
+			errprintf("Failed to send ICMP packet: %s\n", strerror(errno));
+			idx++; /* To avoid looping indefinitely trying to send to this host */
+		}
 	}
 	else if (sentbytes == PING_PACKET_SIZE) {
 		/* We managed to send a ping! */


To unsubscribe from the hobbit list, send an e-mail to
hobbit-unsubscribe (at) hswn.dk

--- End Message ---