[Xymon] Graph titles and NAME: in hosts.cfg - bug? - PATCH

[Japheth Cleaver]

On 4/29/2019 7:14 AM, John Horne wrote:
> On Tue, 2019-04-16 at 22:29 +0000, John Horne wrote:
>> Using Xymon 4.3.28 from the Terabithia RPMs.
>>
>> I've been adding a few new client servers to our Xymon monitor. However, I
>> have noticed today that for some graphs no graph title appears. The graph
>> appears, the values appear (on the graph) and the graph lines appear. Just no
>> title.
>>
>> It seems that this affects those client servers which are configured in the
>> hosts.cfg file with a NAME: entry. For example:
>>
>> 10.11.12.13  server1  # NAME:"server1 (pre-prod web)" testip !ftp ssh...
>>
>> (I don't use FQDNs for the server names.)
>>
>> It seems that entries we have added to the 'graphs.cfg' file, and where the
>> TITLE uses the 'exec:' function have the problem. (See the 'graphs.cfg' man
>> page for info about using 'exec:'.) So, for example we have in graphs.cfg:
>>
>> =======
>> [memory]
>>     TITLE exec:/bin/sh -c 'echo Memory Utilisation - $2'
>>     YAXIS % Used
>>     ...
>> =======
>>
> Hello,
>
> I finally got round to looking into this. I have attached a patch file against
> the 4.3.28 RPMs for the 'web/showgraph.c' file. The patch is only a few lines
> long, and seems to work okay. (All our graphs, those using 'exec:' for the
> title and those not, all appear with their correct titles.)
>
> I have also added a patch for the 'web/graphs.cfg.5' man page. This now
> specifies that the RRD file parameters are double quoted, and if the hostname
> parameter also contains a space then that too will be double quoted.
>
> As always feel free to change around the patches, or remove bits from them, as
> considered necessary :-)
>
Thanks! This has been applied for 4.3.29. I think it's probably better 
to just double-quote the name at all times, though (for consistency).

Regards,

-jc