[Xymon] Graph titles and NAME: in hosts.cfg - bug? - PATCH

[John Horne]

On Tue, 2019-04-16 at 22:29 +0000, John Horne wrote:
>
> Using Xymon 4.3.28 from the Terabithia RPMs.
>
> I've been adding a few new client servers to our Xymon monitor. However, I
> have noticed today that for some graphs no graph title appears. The graph
> appears, the values appear (on the graph) and the graph lines appear. Just no
> title.
>
> It seems that this affects those client servers which are configured in the
> hosts.cfg file with a NAME: entry. For example:
>
> 10.11.12.13  server1  # NAME:"server1 (pre-prod web)" testip !ftp ssh...
>
> (I don't use FQDNs for the server names.)
>
> It seems that entries we have added to the 'graphs.cfg' file, and where the
> TITLE uses the 'exec:' function have the problem. (See the 'graphs.cfg' man
> page for info about using 'exec:'.) So, for example we have in graphs.cfg:
>
> =======
> [memory]
>    TITLE exec:/bin/sh -c 'echo Memory Utilisation - $2'
>    YAXIS % Used
>    ...
> =======
>
Hello,

I finally got round to looking into this. I have attached a patch file against
the 4.3.28 RPMs for the 'web/showgraph.c' file. The patch is only a few lines
long, and seems to work okay. (All our graphs, those using 'exec:' for the
title and those not, all appear with their correct titles.)

I have also added a patch for the 'web/graphs.cfg.5' man page. This now
specifies that the RRD file parameters are double quoted, and if the hostname
parameter also contains a space then that too will be double quoted.

As always feel free to change around the patches, or remove bits from them, as
considered necessary :-)



John.

--
John Horne | Senior Operations Analyst | Technology and Information Services
University of Plymouth | Drake Circus | Plymouth | Devon | PL4 8AA | UK
________________________________
[http://www.plymouth.ac.uk/images/email_footer.gif]<http://www.plymouth.ac.uk/worldclass>

This email and any files with it are confidential and intended solely for the use of the recipient to whom it is addressed. If you are not the intended recipient then copying, distribution or other use of the information contained is strictly prohibited and you should not rely on it. If you have received this email in error please let the sender know immediately and delete it from your system(s). Internet emails are not necessarily secure. While we take every care, University of Plymouth accepts no responsibility for viruses and it is your responsibility to scan emails and their attachments. University of Plymouth does not accept responsibility for any changes made after it was sent. Nothing in this email or its attachments constitutes an order for goods or services unless accompanied by an official order form.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-graphs.cfg.5
Type: text/x-patch
Size: 703 bytes
Desc: patch-graphs.cfg.5
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20190429/326f1dcd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-showgraph.c
Type: text/x-csrc
Size: 1203 bytes
Desc: patch-showgraph.c
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20190429/326f1dcd/attachment.c>