[Xymon] Update on 4.4 (Alpha1 release)

[Ralph M]

Tom,

I realise that you're working with Rocky 8, but I just want to note that
the lib/tcplib.c patch breaks compilation on RHEL7.

The function ASN1_STRING_get0_data() appears in openssl-1.1, but not
in  RHEL7 / openssl-1.0.

I found that there's an openssl version number in the openssl/opensslv.h
include file, which allows the attached patch to select the correct
function.  With this modification to your patch, the compilation completes
on RHEL7, RHEL8 and RHEL9.

Regards,

Ralph Mitchell



On Tue, Oct 3, 2023 at 11:12 PM J.C. Cleaver <cleaver at terabithia.org> wrote:

>
> On Tue, October 3, 2023 13:06, Tom Schmidt wrote:
> >
> > J.C. and 4.4-alpha1 testers,
> >     I have done a little bit of testing of 4.4-alpha1 on Rocky Linux 8.8
> > (server and client) and on a busybox Linux install on a NAS.  I looked
> > into
> > the gcc 8.5.0 compiler warnings that I got on Rocky Linux, and have
> > corrected them, or silenced the ones that should not be an issue.
> > Attached
> > are two context diff patch files, one to fix the compiler warnings, and
> > one
> > to make a couple updates that I had applied to 4.3.30 previously.  My
> > updates fix the busybox Linux client build, and enhance the temperature
> > graph to optionally display both Celsius and Fahrenheit readings.
> >
> >     I have not fully tested 4.4-alpha1 yet, but wanted to get these first
> > patches released for 4.4-alpha2.
> >
> > Tom Schmidt
>
>
> Thanks for the patches!
>
> Yes, the build errors had been a concern for me as well; determining which
> sections were protected by correct math and which weren't was going to
> take some time, and this is quite helpful.
>
> I've created a 4.3.31 branch for similar concerns and many of these are
> just as applicable there. There's also a corruption bug on some loads that
> is crashing on F28 (and F29), so that release will probably just be build
> fixes for the stable tree.
>
> Regards,
> -jc
>
>
>
>
>
>
> _______________________________________________
> Xymon mailing list
> Xymon at xymon.com
> http://lists.xymon.com/mailman/listinfo/xymon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20231004/5a2fe89e/attachment.htm>
-------------- next part --------------
*** ./lib/tcplib.c.orig	2019-04-10 15:33:08.000000000 -0600
--- ./lib/tcplib.c	2023-10-03 22:14:06.254783230 -0400
***************
*** 49,54 ****
--- 49,55 ----
  #include <openssl/ssl.h>
  #include <openssl/rand.h>
  #include <openssl/bio.h>
+ #include <openssl/opensslv.h>
  
  /* SSL context (holds certificate, SSL protocol version etc) for server-mode operation */
  /* Note: Since this is global, we are limited to one server instance per process. */
***************
*** 408,414 ****
  
  		e = X509_NAME_get_entry(subj, cnpos);
  		if (e) d = X509_NAME_ENTRY_get_data(e);
! 		if (d) cn = strdup(ASN1_STRING_data(d));
  	}
  
  	if (peercert) X509_free(peercert);
--- 409,419 ----
  
  		e = X509_NAME_get_entry(subj, cnpos);
  		if (e) d = X509_NAME_ENTRY_get_data(e);
! #if OPENSSL_VERSION_NUMBER < 0x101010bfL
! 		if (d) cn = strdup(ASN1_STRING_data(d));
! #else
! 		if (d) cn = strdup(ASN1_STRING_get0_data(d));
! #endif
  	}
  
  	if (peercert) X509_free(peercert);