[hobbit] Hobbitd_history crashing

[Henrik Stoerner]

On Tue, Jun 14, 2005 at 10:59:31AM -0500, Stuffle, David wrote:
> Hobbit 4.0.4
> Fedora Core 3
> 
> My hobbitd_history has crashed several times in the past few weeks.  It goes
> red with "Fatal signal caught" then it goes purple.  I have core files in
> the server/tmp directory.  Here is the debug output you have requested in a
> previous post.  Thanks!
> 
> #3  0x0804d5de in sigsegv_handler (signum=11) at sig.c:57
> #4  <signal handler called>
> #5  0x0804a242 in main (argc=1, argv=0xfef4a724) at hobbitd_history.c:194

I guess this can happen if a "disable" message does not provide any
cause, i.e. "disable foo.test 180"

Does this patch fix it for you ?


Regards,
Henrik


-------------- next part --------------
--- hobbitd/hobbitd_history.c	2005/04/25 12:39:51	1.36
+++ hobbitd/hobbitd_history.c	2005/06/14 20:17:03
@@ -13,7 +13,7 @@
 /*                                                                            */
 /*----------------------------------------------------------------------------*/
 
-static char rcsid[] = "$Id: hobbitd_history.c,v 1.36 2005/04/25 12:39:51 henrik Exp $";
+static char rcsid[] = "$Id: hobbitd_history.c,v 1.37 2005/06/14 20:16:59 henrik Exp $";
 
 #include <sys/types.h>
 #include <stdio.h>
@@ -158,7 +158,7 @@
 			oldcolor = parse_color(items[8]);
 			lastchg  = atoi(items[9]);
 			disabletime = atoi(items[10]);
-			dismsg   = items[11];
+			dismsg   = items[11]; if (!dismsg) dismsg = "(No reason given)";
 
 			if (save_histlogs) {
 				char *hostdash;