[Xymon] DISPLAYGROUP fails in analysis.cfg

Jeremy Laidman jeremy at laidman.org
Fri Feb 1 09:40:06 CET 2019


On Fri, 1 Feb 2019 at 10:48, Dave "doughnut" Fogarty <doughnut at doughnut.net>
wrote:

> Looks like I just found my answer in the source code.  This is actually
> broken due to someone counting the number of characters incorrectly for a
> strncasecmp in client_config.c.  It's done correctly later in the same
> code.  This should be "13" and "15" where it's "12" and "14".
>
> $ grep -n DISPLAYGROUP= client_config.c
> 466:         (strncasecmp(token, "DISPLAYGROUP=", 12) == 0)     ||
> 467:         (strncasecmp(token, "EXDISPLAYGROUP=", 14) == 0)   ||
> 667:                    else if (strncasecmp(tok, "DISPLAYGROUP=", 13) ==
> 0) {
> 673:                    else if (strncasecmp(tok, "EXDISPLAYGROUP=", 15)
> == 0) {
>

Very nice detective work, Dave. Have you re-compiled with adjustments and
re-tested?

J
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20190201/fb9605e8/attachment.html>


More information about the Xymon mailing list