[hobbit] Possible Bug in 4.3.0-0.20070722 snapshot

[Trent Melcher]

On Fri, 2007-08-17 at 13:38 -0400, Galen Johnson wrote:
> I'm not a C developer but I would've thought that the multigraph
> definition is used to prepend or append your defined tests to a specific
> set of tests that use/require multiple graphs to display nicely...Am I
> mistaken about it's intent?  I trust that it's not working for you since
> you had to go through the trouble of modifying it.
> 
> From what I can tell from your change is you've overwritten the
> defaults, so you'd have to explicitly add them back in.

Correct,  however I have found the true problem and its not in the code
at all.  Its in the instructions given by an earlier poster.  Note that
step 5 suggests to do this:

5)
In etc/hobbitcgi.cfg
Modify the following.
See hobbitsvc.cgi man

CGI_SVC_OPTS="--env=/data/hobbit/server/etc/hobbitserver.cfg  
--no-svcid --history=top --multi-grahs=if_load,if_err..."

Well after looking at the code for hobbitsvc.cgi  its looking for the
option to be --multigraphs=   not --multi-graphs=

So my excercise was all for naught, but Im getting a much better
understanding of the underlying code.

Thanks Henrik for an Awesome product.

Trent


> 
> =G=
> 
> -----Original Message-----
> From: Trent Melcher [mailto:trent.melcher at sitel.com] 
> Sent: Friday, August 17, 2007 1:20 PM
> To: Hobbit at hswn.dk
> Subject: [hobbit] Possible Bug in 4.3.0-0.20070722 snapshot
> 
> 
> I found a possible bug in the 4.3.0-0.20070722  snapshot.
> 
> In the web/hobbitsvc.c (v 1.80 2007/07/18 21:20:15)
> 
> This variable is set:
> static char *multigraphs = ",disk,inode,qtree,";
> 
> With this set the option in the hobbitcgi.cfg for CGI_SVC_OPTS="
> --multi-graphs"   never gets used.  (This is how I found it,  trying to
> use --multi-graphs=if_load,if_err)
> 
> The if statement in the htmllog.c on line 369  is never hit since
> multigraph is never NULL.
> 
> htmllog.c,v 1.59 2007/07/21 16:13:18
> if (multigraphs == NULL) multigraphs = ",disk,inode,qtree,";
> 
> I change the hobbitsvc.c  to
> static char *multigraphs = NULL;
> 
> the if statement in htmllog.c now hits because multigraphs is NULL,
> however could I have possibly broken other tests with this change?  SO
> far I havent found anything broken in my beta deployment of the
> snapshot, Also has this been fixed in newer snapshots?
> 
> 
> 
> Thanks
> Trent
> 
> To unsubscribe from the hobbit list, send an e-mail to
> hobbit-unsubscribe at hswn.dk
> 
> 
> 
> To unsubscribe from the hobbit list, send an e-mail to
> hobbit-unsubscribe at hswn.dk
> 
>