[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [hobbit] PATCH: ignore .rpm* debris in directories included in config files
- To: <hobbit (at) hswn.dk>
- Subject: RE: [hobbit] PATCH: ignore .rpm* debris in directories included in config files
- From: "Cleaver, Japheth" <jcleaver (at) soe.sony.com>
- Date: Thu, 26 Mar 2009 10:00:06 -0700
- References: <7EA6A25EC6360A488E0EBB5F3F21A0DC25467AD7 (at) mail-sd4.ad.soe.sony.com> <200903261052.22588.bgmilne (at) staff.telkomsa.net>
- Thread-index: Acmt8DREzgEInw3qTzG8j5wu77lAIAAQ6A9g
- Thread-topic: [hobbit] PATCH: ignore .rpm* debris in directories included in config files
> -----Original Message-----
> From: Buchan Milne [mailto:bgmilne (at) staff.telkomsa.net]
> Sent: Thursday, March 26, 2009 1:52 AM
> To: hobbit (at) hswn.dk
> Cc: Cleaver, Japheth
> Subject: Re: [hobbit] PATCH: ignore .rpm* debris in directories
included
> in config files
>
> On Tuesday 24 March 2009 23:51:35 Cleaver, Japheth wrote:
> > This patch alters hobbit-wide "directory" include reading logic to
skip
> > files that have been replaced or left over by an RPM install.
> > Specifically, we're splitting hobbitlaunch.cfg into a directory of
> > files, but we don't want to read in things tweaked by a package
upgrade;
> > and there's no way to exclude those in the syntax...
>
> My original proposal for this feature was to support an include
syntax,
> (e.g. include /etc/xymon/hobbitlaunch.d/*.cfg), but this was not
accepted > and instead implemented with the include syntax.
>
> However, a hard-coded rpm-specific solution is probably not going to
be
> any more attractive to merge ...
>
True, a specific include (a la apache's default "include conf.d/*.conf")
would be nice. But there are already exceptions in the code for things
like RCS and .dotfiles. The jump from properly ignoring RCS ",v" stuff
to coping with package-managed versioning as well isn't too far, I don't
think.
-jc