[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [hobbit] Xymon version 4.2.2 RC1 available

I'm not running 4.2 code, but looking at the source for areas I have had some interest in in 4.3, I think there are a few bugs in this: 

hobbitd\rrd\do_ncv.c
------------
1) NCV or SPLITNCV will not recognise signed values.
Line 75: skip past '-' or '+' before strspn call.
2) Potential inconsistent results if SPLITNCV datasource name starts with a non-alphanum. 
Line113: check for outidx==0 before checking dsname[outidx-1]

3) Memory leak in SPLITNCV.
Line 190: call xfree(params[i]) prior to setting params[i] = NULL.
paridx really ought to be reset to 1 here also. As it stands it is reset on the next iteration, but that's really ugly.
4) Lines 198-202 are either unnecessary or dangerous. params[2] is uninitialised at start of routine (line30), or when reinitialised (line 130). This section could possibly attempt to free random values in memory if the routine failed to find any valid SPLITNCV lines in input. Unnecessary if valid SPLITNCV lines found.
5) This routine will not recognise input lines with &{RED|YELLOW|GREEN} prior to the dsname. Maybe this was a 4.3 functional improvement? (4.3 code sits between lines 72 and 73 of this file). 

hobbitd\client\bbwin.c
-------------------
6) Timediff from BBWIN clients with central configuration.
The BBWIN client 0.12 reports its epoch as whole seconds only, without the decimal part. The current code fails if no decimal part is supplied. So in hobbitd\client\bbwin.c, function bbwin_clock_report() replace the lines 186-7 
               p = strstr(clockstr, "epoch:");
if (p && (sscanf(p, "epoch: %ld.%ld", (long int *)&clockval.tv_sec, (long int *)&clockval.tv_usec) == 2)) { 
by
               int fields;

               p = strstr(clockstr, "epoch:");
               clockval.tv_usec = 0;
               if (!p)
                     ; /* do nothing further */
else if( (fields = sscanf(p, "epoch: %ld.%ld", (long int *)&clockval.tv_sec, (long int *)&clockval.tv_usec)) < 1) 
                    dbgprintf("Failed to parse time from '%s'\n", p);
               else {

This will now accommodate either decimal or integer timestamps

Graham Nayler
----- Original Message ----- From: "Henrik Størner" <henrik (at) hswn.dk> 
To: <hobbit (at) hswn.dk>
Cc: "Hobbitmon-developer" <hobbitmon-developer (at) lists.sourceforge.net>
Sent: Monday, December 01, 2008 12:08 PM
Subject: [hobbit] Xymon version 4.2.2 RC1 available



I've just made the release-candidate of version 4.2.2 available
for download on Sourceforge.

https://sourceforge.net/project/showfiles.php?group_id=128058&package_id=140220&release_id=644075

This is how I would expect the interim 4.2.2 release to be.
It includes the following changes from 4.2.0:

*) Due to the Hobbit project being renamed to Xymon (for
  legal reasons), the documentation has been updated to
  refer to this as the name of the project.
*) All patches from the "all-in-one" patch have been applied
*) Patches from Debian and Mandriva source archives and
  elsewhere have been merged, fixing:
  - The "Critical Systems" configuration report would crash
    when hosts were in NKview.cfg, but no NK tags were in
    bb-hosts (from Mandriva)
  - SSL certificates with 4-digit expiration years would
    crash the network tester (from Debian)
  - Newer OpenLDAP versions have a different API, so
    the LDAP test code would not build correctly (from
    Debian)
  - Old Big Brother clients report disk output with no
    header line (from Debian)
  - The bb-hosts syntax for HTTP testing via a proxy
    could not support https target-URL's (from Debian)
  - Certain SuSE versions would not be identified by
    the Linux client as such (only affected OS name
    displayed in the "info" status).
*) Support for sending custom graph data in a "trends"
  data message (from
  http://www.hswn.dk/hobbiton/2007/01/msg00236.html)
*) Split-NCV and TRACKMAX support for custom graphs (from
  http://www.hobbitmon.com/hobbiton/2007/03/msg00368.htm).
*) Support for the "BBWin" client http://bbwin.sf.net/
  in centralized (server-side) configuration mode.
  Based on BBWin v. 0.12.
*) Support for the "hobbit-perl-client" add-on
  http://hobbit-perl-client.sf.net/ .
  Based on perl-http-client v1.15
*) Support for the "Devmon" SNMP data collector
  http://devmon.sf.net/ based on Devmon 0.3.0.

A last-minute update for Devmon was missed in the RC1
source file, so Devmon users should grab the latest
hobbitd/rrd/do_devmon.c source from
http://hobbitmon.svn.sourceforge.net/viewvc/hobbitmon/branches/4.2.2/hobbitd/rrd/do_devmon.c?revision=6002
and copy to hobbitd/rrd/do_devmon.c . This will be included
in the final 4.2.2 release.

Please test this if you can, and report problems to the
mailing list. Since all of this code has been in use for
quite some time, I would not expect a lot of problems.
So the target date for the 4.2.2 release is Dec. 10.


Regards,
Henrik


To unsubscribe from the hobbit list, send an e-mail to
hobbit-unsubscribe (at) hswn.dk