Re: [hobbit] Darwin clients: empty memory graph

[Dominique Frise <Dominique.Frise (at) unil.ch>]

Dominique Frise wrote:
> Hi,
>
> With today's snapshot the memory graph is still empty :-(
> Memory/Used/Total/Percentage info is reported correctly (only one line 
> for Physical)
>
> Same issue with Darwin 8.6.0 (OSX 10.4.6) or 7.9.0 (OSX 10.3.9)
>
>
> Dominique
> UNIL - University of Lausanne
>
> To unsubscribe from the hobbit list, send an e-mail to
> hobbit-unsubscribe (at) hswn.dk

We had to ack hobbitd/rrd/do_memory.c to make this work:


[super (at) iris rrd]# diff -u do_memory.c.dist do_memory.c
--- do_memory.c.dist	Thu May  4 17:30:37 2006
+++ do_memory.c	Wed May 17 09:44:35 2006
@@ -118,7 +118,7 @@
 		swap = strstr(msg, "Swap"); if (swap == NULL) swap = strstr(msg, "Page");
 		actual = strstr(msg, "Actual"); if (actual == NULL) actual = strstr(msg, 
"Virtual");

-		if (phys && swap) {
+		if (phys) {
 			char *eoln;
 			int physval = -1, swapval = -1, actval = -1;

@@ -125,11 +125,13 @@
 			eoln = strchr(phys, '\n'); if (eoln) *eoln = '\0';
 			physval = get_mem_percent(phys);
 			if (eoln) *eoln = '\n';
+			
+			if (swap) {
+				eoln = strchr(swap, '\n'); if (eoln) *eoln = '\0';
+				swapval = get_mem_percent(swap);
+				if (eoln) *eoln = '\n';
+			}

-			eoln = strchr(swap, '\n'); if (eoln) *eoln = '\0';
-			swapval = get_mem_percent(swap);
-			if (eoln) *eoln = '\n';
-
 			if (actual) {
 				eoln = strchr(actual, '\n'); if (eoln) *eoln = '\0';
 				actval = get_mem_percent(actual);



Henrik, thanks to notice this for next snapshot.

Dominique
UNIL - University of Lausanne