RE: [hobbit] badTEST:x:y:z not working

["Eric van de Meerakker" <eric.vdm (at) softlution.com>]

Hello Henrik,


Just to confirm this: your patch seems to be working OK. I set
"badhttp:0:1:2" and have now seen the http test go from green to yellow
before turning red.

Thanks! This will keep down the number of false alerts.


Eric
________________________________________

mail to : Eric.vdM (at) Softlution.com
phone   : +31 (0)40 235 0506
fax     : +31 (0)40 235 0581
________________________________________


-----Original Message-----
From: Henrik Stoerner [mailto:henrik (at) hswn.dk] 
Sent: Thursday, August 11, 2005 3:49 PM
To: hobbit (at) hswn.dk
Subject: Re: [hobbit] badTEST:x:y:z not working

On Thu, Aug 11, 2005 at 01:46:16PM +0200, Heinecke (at) hansenet.com wrote:
> Dear all,
>  
> looks to me, as if the "badTEST:x:y:z" tags are not working. 
>  
> I.e. "badssh:1:2:3" turns immediatley red if ssh goes down at the
monitored host. 

There has been some reports about this, but I never got around to
looking into exactly what caused it.

> I've looked into bbtest-net.c and figured out, that ..
>  
> - At line 775, the for loop << "for (swalk=svchead; (swalk &&
strcmp(swalk->testname, testname)); swalk = swalk->next) >>
> compares swalk->testname and testname ---> which are never equal, because
the string testname always includes the :x.y:z settings and swalk->testname
(of course) not.

Aha - that would explain it.

I think this patch should fix it, then.


Henrik