Re: [hobbit] post-RC3 patch problems

[Henrik Stoerner <henrik (at) hswn.dk>]

On Thu, Feb 24, 2005 at 12:35:05PM -0500, Jeffcoat, Al wrote:

> After applying post-RC3 patch, I'm still getting the following issues:
> 
> During the ./configure
> 
> --- snip ---
> 
> What userid will be running Hobbit [hobbit] ?
> 
> /configure[215]: getent:  not found.
> 
> Found passwd entry for user hobbit:*:203:201::/home/hobbit:/usr/bin/ksh

This is harmless - if getent exists, it is used; if not, configure
will do a grep on /etc/passwd. I'll have it send the error to
/dev/null.


> Firefox:
> 
> When clicking on bbtest or hobbitd_larrd icons, I can at least get to
> the page, but get a warning that says "Program Crashed", fatal signal
> caught, for those two icons.
> 
> No Apache errors are generated when Firefox is used.

The hobbitd_larrd icon normally does not exist - it's a symptom of the
problems in RC3 that caused hobbitd_larrd to crash. Remove the
hobbitd_larrd icon with 
   ~/server/bin/bb 127.0.0.1 "drop SERVERNAME hobbitd_larrd"

bbtest-net shouldn't crash. It could be affected by the same bug
that hobbitd_larrd had. If it continues to show this message (and the
timestamp changes), I'm interested in a copy of your bbtest-net 
binary and the core file it generates.

> Internet Explorer:
> 
> When I click on bbtest or hobbitd_larrd, I get an Internal server error.
> 
> Here's what I get in the Apache error log for an IE hit: 
> 
> [Thu Feb 24 12:30:49 2005] [error] [client 10.254.15.4] Premature end of
> script headers: bb-hostsvc.sh, referer: http://hobbit/

I have no idea why IE triggers this when Firefox doesn't.


> 2005-02-24 12:18:00 Worker process died with exit code 393350, terminating.
> 2005-02-24 12:17:10 Task larrdstatus terminated, status 1
> 2005-02-24 12:18:06 Task bbnet terminated by signal 6

These are after you installed the post-RC3 patch ? In that case, could
you try if adding the attached patch makes these go away ?


> I've tried to include all the relevant information.  Also, is there a
> list archive for this list, where I can search for similar issues?  I
> thought I had seen a few issues like mine (with possible resolutions),
> but now cannot find them in my e-mail.

http://www.hswn.dk/hobbiton/ has an archive. The monthly split does
not work, so if you click on February you get both the January and
February postings - I'll get that fixed once I have a bit more time:-)


Regards,
Henrik

--- lib/netservices.c	2005/02/22 13:59:58	1.3
+++ lib/netservices.c	2005/02/24 18:51:20
@@ -11,7 +11,7 @@
 /*                                                                            */
 /*----------------------------------------------------------------------------*/
 
-static char rcsid[] = "$Id: netservices.c,v 1.3 2005/02/22 13:59:58 henrik Exp $";
+static char rcsid[] = "$Id: netservices.c,v 1.4 2005/02/24 18:51:11 henrik Exp $";
 
 #include <ctype.h>
 #include <string.h>
@@ -121,7 +121,7 @@
 	svclist_t *head, *tail, *first, *walk;
 	char *searchstring;
 	int svcnamebytes = 0;
-	int svccount = 1;
+	int svccount = 0;
 	int i;
 
 	filename[0] = '\0';
@@ -251,8 +251,8 @@
 	if (fd) fclose(fd);
 
 	/* Copy from the svclist to svcinfo table */
-	svcinfo = (svcinfo_t *) malloc(svccount * sizeof(svcinfo_t));
-	for (walk=head, i=0; (walk); walk = walk->next, i++) {
+	svcinfo = (svcinfo_t *) malloc((svccount+1) * sizeof(svcinfo_t));
+	for (walk=head, i=0; (walk && (i < svccount)); walk = walk->next, i++) {
 		svcinfo[i].svcname = walk->rec->svcname;
 		svcinfo[i].sendtxt = walk->rec->sendtxt;
 		svcinfo[i].sendlen = walk->rec->sendlen;
@@ -262,6 +262,13 @@
 		svcinfo[i].flags   = walk->rec->flags;
 		svcinfo[i].port    = walk->rec->port;
 	}
+	memset(&svcinfo[svccount], 0, sizeof(svcinfo_t));
+
+	/* This should not happen */
+	if (walk) {
+		errprintf("Whoa - didnt copy all services! svccount=%d, next service '%s'\n", 
+			svccount, walk->rec->svcname);
+	}
 
 	/* Free the temp. svclist list */
 	while (head) {