[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [hobbit] vmstat graphing with CPU io wait
Tom Georgoulias wrote:
> Patch - on top of the previous one - attached. It compiles, but
> I haven't tested it. It assumes your vmstat data sends in
> "rhel3" as the name of the OS.
I was going to share the patch I created, which looks almost the same,
but I went ahead and used yours instead, though, just to be in sync
with your sources.
I think I spoke too soon. My Red Hat 7.1/7.3 systems need to use the
same layout as debian3, so I had that in my patch. I also created the
cpu_wait column for my freebsd systems, but left it undefined so that
every system could use the same vmstat graph. For those that track
IOwait, it'll use it. For those that do not, the parameter will show up
in the legend and keep the value "nan". Not the prettiest, but much
easier to maintain. Patch is attached, which relies on yours already
being in place, in case you are interested. I hesitate to push for
inclusion since RH 8.0, 9 and what ever else is out there may report
their BBOSNAME as "redhat" but use a different vmstat, plus not everyone
wants their graphs to include a parameter that might not exist. It's
out there for whoever wants to use it.
I also included a simple, tiny patch to add an echo statement for
starthobbit.sh that tells the user hobbit is stoppped, much like the
message displayed when starting. I put it there as a way to clarify
what is happening when the rest of my team starts messing around with
hobbit. I'm thinking of creating a new symlink called "runhobbit.sh",
just to match the old BB style and to try and avoid any confusion that
may go along with a command that looks like this "starthobbit.sh stop"
Tom
--- hobbitd/starthobbit.sh.DIST.orig 2005-01-27 10:26:53.000000000 -0500
+++ hobbitd/starthobbit.sh.DIST 2005-01-27 10:27:09.000000000 -0500
@@ -30,6 +30,7 @@
if test -s @BBLOGDIR@/hobbitlaunch.pid
then
kill -TERM `cat @BBLOGDIR@/hobbitlaunch.pid`
+ echo "Hobbit stopped"
fi
;;
--- hobbitd/larrd/do_vmstat.c.orig 2005-01-27 08:22:32.000000000 -0500
+++ hobbitd/larrd/do_vmstat.c 2005-01-27 10:17:17.000000000 -0500
@@ -186,6 +186,8 @@
{ 16, "cpu_sys" },
{ 17, "cpu_usr" },
{ 18, "cpu_idl" },
+/* not collected, but allows freebsd to use same vmstat larrd def as redhats. tomg */
+ { -1, "cpu_wait" },
{ -1, NULL }
};
@@ -241,9 +243,11 @@
case OS_HPUX:
layout = vmstat_hpux_layout; break;
case OS_LINUX:
- case OS_REDHAT:
case OS_DEBIAN:
layout = vmstat_linux_layout; break;
+ /* RHL 7.1/7.3 use older vmstat output */
+ case OS_REDHAT:
+ layout = vmstat_debian3_layout; break;
case OS_RHEL3:
layout = vmstat_rhel3_layout; break;
case OS_DEBIAN3: