[Xymon] Trends graph limit

[Jeremy Laidman]

Mario

No that's not correct. All I did was add "+strlen(onelink)" to the existing
line that calls SBUF_REALLOC(). So it went from this:

SBUF_REALLOC(allrrdlinks,
allrrdlinks_buflen+4096);

to this:

SBUF_REALLOC(allrrdlinks,
allrrdlinks_buflen+strlen(onelink)+4096);

Then recompile.

Rather than doing a "make install", I would have copied just the
svcstatus.sh file produced by the compile, in place of the existing file
(after making a backup), and set the ownership and permissions to match.

Actually, I probably would have tested it first, by copying the new file
into place with a different filename, and adjusting the url for a Trends
page in my browser to use the new filename. Then when the trends page
showed correctly, replaced the original file.

Cheers
Jeremy


On Mon, 3 June 2024, 02:30 Mario, <rower.master at gmail.com> wrote:

> Hello Jeremy,
>
>
> The fix you have applied was just change line 213 in
> xymon-4.3.30/web/svcstatus-trends.c
>
> from
>                                 SBUF_REALLOC(rrdlink, rrdlink_buflen +
> strlen(partlink) + 4096);
> to
>
>  SBUF_REALLOC(allrrdlinks, allrrdlinks_buflen+strlen(onelink)+4096);
>
> and recompile?
>
>
>
> Thanks & regards,
>
> Mario
>
>
>
>
>
> On Fri, May 31, 2024 at 7:28 PM Jeremy Laidman <jeremy at laidman.org> wrote:
>
>> Weird flex, I know, but we have trends pages exceeding 100 graphs. One
>> pair of hosts has 144 graphs each.
>>
>> The code has no constraint on the number of graphs. The limitations are
>> likely to be memory on the server and the client.
>>
>> The fix we applied here (described in my post last August) has been
>> entirely successful in preventing the core dump. At the time, JC asked for
>> a core dump to confirm the fault/fix, but I haven't been able to provide
>> this due to my workload and other things going on around me at the time.
>> It's non-trivial for me to arrange for another core dump at this time.
>>
>> J
>>
>> On Sat, 1 Jun 2024 at 06:27, Mario <rower.master at gmail.com> wrote:
>>
>>> Hello Tom,
>>>
>>> I think I have the same issue described by Jeremy here
>>> https://lists.xymon.com/archive/2023-August/048118.html and replied by
>>> JC here https://lists.xymon.com/archive/2023-September/048122.html
>>> In my old Xymon server version I have no issues with trends column.
>>>
>>>
>>>
>>> Thanks & regards,
>>> Mario
>>>
>>>
>>>
>>>
>>> On Thu, May 30, 2024 at 9:25 PM Tom Schmidt <tom at 4schmidts.com> wrote:
>>>
>>>> Mario,
>>>>     I don't see any such limit, as my xymon server has 27 graphs under
>>>> its trends.
>>>>
>>>> Tom Schmidt
>>>>
>>>> On Thu, May 30, 2024 at 5:05 PM Mario <rower.master at gmail.com> wrote:
>>>>
>>>>> Hello All,
>>>>>
>>>>> Do trends column have a limitation in number of graphs to load?
>>>>> I can see that is stopping after loading 21 graphs.
>>>>> Is it configurable?
>>>>>
>>>>> My Xymon version is 4.3.30
>>>>>
>>>>> Thanks in advance.
>>>>>
>>>>>
>>>>> Br,
>>>>> Mario
>>>>> _______________________________________________
>>>>> Xymon mailing list
>>>>> Xymon at xymon.com
>>>>> http://lists.xymon.com/mailman/listinfo/xymon
>>>>>
>>>> _______________________________________________
>>> Xymon mailing list
>>> Xymon at xymon.com
>>> http://lists.xymon.com/mailman/listinfo/xymon
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20240603/29dffcf7/attachment.htm>