[Xymon] small bug, problem with build (since 4.3.13 ?)

[J.C. Cleaver]

On Wed, February 12, 2014 6:17 am, henrik at hswn.dk wrote:
> Den 2014-02-12 10:33, Sergey skrev:
>> Hello.
>>
>> xymon/build/Makefile.rules contains
>> find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod
>> 644
>>
>> what about to change it ? For example to
>> find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -exec chmod 644 {} \;
>>
>> Some time $(INSTALLWWWDIR) may be empty. Building brake at this case:
>>
>
> I don't quite understand how this can be. The $(INSTALLWWWDIR)
> directory should always have some files in it - e.g. the gifs and help
> files that get installed prior to the line that breaks.
>
>> make[1]: Leaving directory `/home/builder/RPM/BUILD/xymon-4.3.13/web'
>> find /home/builder/tmp-build/xymon-buildroot/var/www/xymon -type f
>> -print0 | xargs -0 chmod 644
>> chmod: missing operand after `644'
>> Try `chmod --help' for more information.
>
> Here it seems like you are building an RPM package. Are you sure this
> isn't caused by some error in the spec-file ?
>
>
> Regards,
> Henrik

I remember seeing this while doing PKGBUILD=1 builds in my RPM too,
starting right in the 4.3.13 release. I patched around it (below) and
promptly forgot about it... but never tracked down precisely what had
changed in the build path. It could be affecting yours too.


HTH,

-jc



--- build/Makefile.rules.safexargs      2014-01-09 12:54:44.780844602 -0800
+++ build/Makefile.rules        2014-01-09 12:59:00.575844602 -0800
@@ -332 +332 @@
-       find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0
chmod 644
+       find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -r -0
chmod 644