[Xymon] enadis page only showing the last scheduled disable

[Bakkies Gatvol]

Big thanks for the fix from over here!

About 3 weeks into running 4.3.17 here, we found the bug.  

From: larry at fni-stl.com
To: xymon at xymon.com
Date: Thu, 31 Jul 2014 15:39:26 +0000
Subject: Re: [Xymon] enadis page only showing the last scheduled disable








I believe I have this problem identified and corrected. 
xymond schedule list query was not returning a newline after each scheduled entry. 
headfoot.c was not parsing it correctly since it was looking for a newline. 
So it wound up only displaying the last portion of the multi-line output.
 
What really concerns me though is that apparently no one has had this problem (or reported it) for 5 months since 4.3.17 was released. 
That doesn't sound probable with such a basic program feature as Enable/Disable Alerts. 
Which makes me think I may have something else in play here.
 
But the change I made to xymond.c has fixed my problem and I can't find any new issues that I created with the modification.
 
Larry
 
-------------------------------------------------------------------------------------------------
 
Schedule list output from 4.3.17:
 
4.3.17 $ bin/xymon localhost 'schedule'
 
2|1406853120|192.168.34.1|disable testsys31.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n1|1406853120|192.168.34.1|disable testsys32.* 240 \nDisabled
 by: larry @ 192.168.84.1\nReason: test\n
 
 
Schedule list output from 4.3.12:
 
4.3.12 $ bin/xymon localhost 'schedule'
 
7|1406854500|192.168.62.1|disable testsys3.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n
6|1406854500|192.168.62.1|disable testsys1.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n
5|1406854500|192.168.62.1|disable testsys.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n
 
 
Added newline to each task listing at line 4169 in xymond/xymond.c
 
4.3.17/xymond # diff xymond.c 
xymond.c.ORIG
4169c4169
<                              
addtobuffer_many(response, 
tbuf, "|", swalk->sender, "|", 
nlencode(swalk->command), "\n", NULL);
---
>                              
addtobuffer_many(response, 
tbuf, "|", swalk->sender, "|", 
nlencode(swalk->command), NULL);
 
 
Schedule list output following the change:
 
4.3.17 $ bin/xymon localhost 'schedule'
 
4|1406852940|192.168.34.1|disable testsys31.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n
3|1406852940|192.168.34.1|disable testsys32.* 240 \nDisabled by: larry @ 192.168.84.1\nReason: test\n
 

 
 
 


From: Xymon [mailto:xymon-bounces at xymon.com]
On Behalf Of Larry Bonham

Sent: Tuesday, July 29, 2014 4:16 PM

To: 'xymon at xymon.com'

Subject: Re: [Xymon] enadis page only showing the last scheduled disable


 

Anyone able to help me with this problem?  I'm pretty much dead in the water with my 4.3.17 upgrade.
 
Something left over from my 4.3.12 configuration?  I assume it is not a widespread issue.
 
Larry
 


From: Xymon [mailto:xymon-bounces at xymon.com]
On Behalf Of Larry Bonham

Sent: Friday, July 25, 2014 9:34 AM

To: 'xymon at xymon.com'

Subject: [Xymon] enadis page only showing the last scheduled disable


 

I saw where this was reported but I couldn't find any follow-up mention of a fix or cause.
 
Just updated from xymon 4.3.12 to 4.3.17 on a RHEL 6.5 system.  Now when I use the enadis page in the Scheduled Actions section it is only showing the last system that has a scheduled disable.  Instead of the full list of pending disables.

 
Thanks.
 
Larry

 
 







CONFIDENTIALITY NOTICE:

This electronic mail message is intended exclusively for

recipient to which it is addressed. The contents of this message

and any attachments may contain confidential and privileged

information. Any unauthorized review, use, print, storage, copy,

disclosure or distribution is strictly prohibited. If you have

received this message in error, please advise the sender

immediately by replying to the message's sender and delete all

copies of this message and its attachments without disclosing

the contents to anyone, or using the contents for any purpose.





_______________________________________________
Xymon mailing list
Xymon at xymon.com
http://lists.xymon.com/mailman/listinfo/xymon 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20140819/9e866d8f/attachment.html>