[Xymon] make install bug?

[Nikolai Lifanov]

Not really?

The bigger issue here is that the "./configure" is not re-locatable.
So, no workflow like "mkdir xymon-build; cd xymon-build;
../xymon-code/configure; ..."
This means that you really ought to "svn export" your check-in into your
working directory.

Release tarballs already do this. 

The better fix is to get autotools to define $(INSTALL) program (or just
skip it and use "install" command) and refactor
the individual targets to do this instead of "cp -fr" and "chmod/chown".
This example bypasses checks for PKGBUILD, which could in turn be
implemented as a conditional unset of $(INSTALL_ARGS) ifndef PKGBUILD. 

Example:
Index: web/Makefile
===================================================================
--- web/Makefile (revision 7314)
+++ web/Makefile (working copy)
@@ -272,28 +272,21 @@
 install: install-bin install-cgi install-man

 install-bin:
+INSTALL_ARGS = ""
 ifndef PKGBUILD
- chown $(XYMONUSER) $(PROGRAMS)
- chgrp `$(IDTOOL) -g $(XYMONUSER)` $(PROGRAMS)
- chmod 755 $(PROGRAMS)
+INSTALL_ARGS = "-m 755 -o $(XYMONUSER) -g $(XYMONUSER)"
 endif
- cp -fp $(PROGRAMS) $(INSTALLROOT)$(INSTALLBINDIR)/
+ install $(INSTALL_ARGS) 
+ $(PROGRAMS) $(INSTALLROOT)$(INSTALLBINDIR)/
+ 

Your other option is to replace "cp -fr" and "chmod/chown" invocation
with invocations of "install". 

On 2013-11-02 12:52, Steve Coile wrote: 

> Downloaded _xymon-4.3.12.tar.gz_, unpacked it, checked it in to SVN, _./configure_, _make_, _make install_, tried to check-in resulting installation, found copies of _.svn_ directories from the source tree under the installed _server/www/help/manpages_. This strikes me as a bug, no?
> 
> -- 
> Steve Coile
> Senior Network and Systems Engineer, McClatchy Interactive [2] 
> Office: 919-861-1247 | Mobile: 919-622-5369 | Fax: 919-861-1300 
> 
> _______________________________________________
> Xymon mailing list
> Xymon at xymon.com
> http://lists.xymon.com/mailman/listinfo/xymon [1]

 

Links:
------
[1] http://lists.xymon.com/mailman/listinfo/xymon
[2] http://www.mcclatchyinteractive.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20131102/60e5de92/attachment.html>