[Xymon] Feature Request ~ logfetch

[Novosielski, Ryan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/25/2013 03:55 PM, Michael Beatty wrote:
> I see the comments made in logfetch.c
> 
> /* Is it ok for these to be hardcoded ? */ #define MAXCHECK
> 102400   /* When starting, dont look at more than 100 KB of data
> */ #define MAXMINUTES 30 #define POSCOUNT ((MAXMINUTES / 5) + 1) 
> #define LINES_AROUND_TRIGGER 5
> 
> My answer to this would be, "no".
> 
> Due to various reasons, it is not desirable to run my client more
> than once every hour.  Therefore, the msgs check for log files is
> almost useless unless I change these values (and honestly, I'm not
> even sure that would work as I haven't seen if this would impact
> anything else). If I ran my client every hour, I would lose 50% of
> my log data.
> 
> I would like to see where the log check would be dependent on how
> long of an interval your client is run as opposed to a hard coded
> 30 minutes.

I personally have no need for this change at the moment, but I agree
that no it's not OK for them to be hardcoded. Seems to be an easy
enough change to make and there's virtually no benefit (that I can
think of) to hard coding.

- -- 
- ---- _  _ _  _ ___  _  _  _
|Y#| |  | |\/| |  \ |\ |  | |Ryan Novosielski - Sr. Systems Programmer
|$&| |__| |  | |__/ | \| _| |novosirj at umdnj.edu - 973/972.0922 (2-0922)
\__/ Univ. of Med. and Dent.|IST/EI-Academic Svcs. - ADMC 450, Newark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlEr22YACgkQmb+gadEcsb5S4gCgrYiBbt8dpOpTIHUMU+ZAnTpk
fKAAoM4KnoMvConjfpfopXSuWcvkf8zC
=p+0J
-----END PGP SIGNATURE-----