[Xymon] Bug in xymon 4.3.4 null template

[Peter Maguire]

*Bug has consequences near line 213* do_rrd.c, function
flush_cached_updates.

extract from rrd-status.log

3451 2011-09-01 15:04:31 Sending from devmon to RRD for temp ACpu0Core1:
1314853471:45.0
3451 2011-09-01 15:04:31 Flushing '/upeterm/temp.ACpu0Core1.rrd' with 2
updates pending, template *'(null)'*

2011-09-01 15:04:31 RRD error updating
/usr/local/xymon/data/rrd/upeterm/temp.ACpu0Core1.rrd from 127.0.0.1:
unknown option *'-t'*

xymond_rrd crashing

*gdb report*

#0  0x00007f7699d33d05 in raise (sig=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007f7699d37ab6 in abort () at abort.c:92
#2  0x000000000042dc43 in sigsegv_handler (signum=<value optimised out>)
at sig.c:51
#3  <signal handler called>
#4  __strncasecmp_l_ssse3 () at ../sysdeps/x86_64/multiarch/../strcmp.S:2113
#5  0x000000000041fd12 in setup_template (params=<value optimised out>)
at xymonrrd.c:337
#6  0x00000000004066cf in create_and_update_rrd (hostname=<value
optimised out>, testname=<value optimised out>, classname=0x7f769a8b226d
"services",
    pagepaths=0x7f769a8b2276 "0", creparams=0x7fff9d827cc0,
template=<value optimised out>) at do_rrd.c:501
#7  0x0000000000412e4b in do_devmon_rrd (hostname=0x7f769a8b221f
"upeterm", testname=0x7f769a8b2227 "motherboard",
classname=0x7f769a8b226d "services",
    pagepaths=0x7f769a8b2276 "0", msg=<value optimised out>,
tstamp=1314851366) at rrd/do_devmon.c:108
#8  0x0000000000413dd5 in update_rrd (hostname=0x7f769a8b221f "upeterm",
testname=0x7f769a8b2227 "motherboard", msg=<value optimised out>,
tstamp=1314851366,
    sender=<value optimised out>, ldef=<value optimised out>,
classname=0x7f769a8b226d "services", pagepaths=0x7f769a8b2276 "0") at
do_rrd.c:760
#9  0x0000000000403411 in main (argc=<value optimised out>, argv=<value
optimised out>) at xymond_rrd.c:351



*with xymon compiled with debugging suppor*t
CFLAGS = -g -DDEBUG -Wall -D_REENTRANT $(LFSDEF) $(OSDEF) enabled

no more null template, xymond_rrd not crashing

attached is script that collects the data that triggers the problem

*Versions*

xymon is at 4.3.4

OS

Distributor ID: Ubuntu
Description:    Ubuntu 11.04
Release:        11.04
Codename:       natty

Linux upeterm 2.6.38-11-server #48-Ubuntu SMP Fri Jul 29 19:20:32 UTC
2011 x86_64 x86_64 x86_64 GNU/Linux


suggest you add
if ( cacheitem->tpl->template != NULL) {
    :
}

around your code to protect yourself from yourself


Peter


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20110902/08b6af87/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: motherboard.pm
Type: text/x-perl
Size: 6811 bytes
Desc: not available
URL: <http://lists.xymon.com/pipermail/xymon/attachments/20110902/08b6af87/attachment.pm>