[Xymon] make install overwrites xymon-apache.conf (and creates unnecessary bak files)

[Henrik Størner]

On 07-12-2011 12:59, SebA wrote:
> On the latest trunk, a make install overwrites xymon-apache.conf without
> either merging in my additions to it, or making a backup of the existing
> file. This resulted in me losing the additions that I made to it on
> Monday. Rather annoying.

Indeed. I've changed the installation so it will not overwrite an 
existing file.

> As a small aside, another untidyness is that the make install process
> seems to be creating backup copies of files that have NOT changed since
> the last install:
> [etc]# ls -l | grep "Dec 7"
> -rw-r--r-- 1 hobbit hobbit 3374 Dec 7 11:21 cgioptions.cfg
> -rw-r--r-- 1 hobbit hobbit 3374 Dec 7 11:21 cgioptions.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 4193 Dec 7 11:21 client-local.cfg
> -rw-r--r-- 1 hobbit hobbit 4193 Dec 7 11:21 client-local.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 11524 Dec 7 11:21 columndoc.csv
> -rw-r--r-- 1 hobbit hobbit 11524 Dec 7 11:21 columndoc.csv.bak
> -rw-r--r-- 1 hobbit hobbit 0 Dec 7 11:22 cookies.session
> -rw-rw-r-- 1 hobbit apache 0 Dec 7 11:21 critical.cfg
> -rw-rw-r-- 1 hobbit apache 0 Dec 7 11:21 critical.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 74994 Dec 7 11:21 graphs.cfg
> -rw-r--r-- 1 hobbit hobbit 74994 Dec 7 11:21 graphs.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 4674 Dec 7 11:21 protocols.cfg
> -rw-r--r-- 1 hobbit hobbit 4674 Dec 7 11:21 protocols.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 11118 Dec 7 11:21 tasks.cfg
> -rw-r--r-- 1 hobbit hobbit 11118 Dec 7 11:21 tasks.cfg.bak
> -rw-r--r-- 1 hobbit hobbit 4615 Dec 7 11:17 xymon-apache.conf
> -rw-r--r-- 1 hobbit hobbit 12784 Dec 7 11:21 xymonserver.cfg
> -rw-r--r-- 1 hobbit hobbit 12784 Dec 7 11:21 xymonserver.cfg.bak
>
> I believe all of these bak files are the same as the originals.

Probably, if you didn't change the Xymon build configuration.

> Presumably the previous bak files were lost during this process, which
> is potentially rather annoying too!

Saving a backup file has to be your own responsibility. The Xymon 
installer should take care to save the current config-files before 
writing new ones, and that it what it does - it doesn't do version 
control of your setup.


Regards,
Henrik