[Xymon] Acknowledge issue continues with xymon 4.3.2

[Clark, Sean]

Just so anyone else following this thread is aware, the diff is for the
trunk version, not the 4.3.2 release, although you could prolly figure it
out for the 4.3.2 if you were so inclined






On 4/8/11 9:14 AM, "Clark, Sean" <sean.clark at twcable.com> wrote:

>
>Thank you I will install this post haste.
>
>Hope your surgery goes well, try not to look at bright lights for a while
>:-D
>
>
>
>
>
>
>
>
>On 4/7/11 5:02 PM, "Henrik Størner" <henrik at hswn.dk> wrote:
>
>>Den 07-04-2011 15:45, Clark, Sean skrev:
>>> But I can say, using the webpage default method produces the same error
>>> messages "Cookie not found" -- so I didn't think it would be my method
>>>of
>>> acknowledging
>>
>>Ok, that would have been my next question :-)
>>
>>It is quite possible that it's a bug in the xymond code. I don't know
>>why it hits you so much, but that is kind of irrelevant.
>>
>>Inside xymond, the cookies are stored in a datastructure called a
>>"red-black tree" ("rbtree" for short). This uses some code that I picked
>>up from someone else - it is used in lots of places, e.g. all of the
>>hosts.cfg configuration is also stored in a similar datastructure.
>>
>>However, the cookie-handling is special because it cookies are
>>frequently deleted (hosts being removed happens much less frequently). I
>>have had some crashes that I could never really explain when hosts were
>>removed, and I really do suspect that particular bit of code that
>>deletes an entry from the rbtree to be buggy. Therefore, it could very
>>well be that there is a real problem here.
>>
>>I've come up with a version of xymond.c that eliminates the rbtree code
>>for the cookies. It uses a much less efficient way of looking up the
>>cookies - basically, it will scan through all of the status-log entries
>>that xymond has in memory - but since this only happens when a cookie
>>needs to be renewed, or when xymond receives an ack, it should not put
>>too much extra load on your system. It would be very interesting to hear
>>if this patch on top of 4.3.2 solves the issue; if it does, then I
>>surely know that there is a bug in the rbtree "delete node" code.
>>
>>Regards,
>>Henrik
>>
>>
>
>
>This E-mail and any of its attachments may contain Time Warner Cable
>proprietary information, which is privileged, confidential, or subject to
>copyright belonging to Time Warner Cable. This E-mail is intended solely
>for the use of the individual or entity to which it is addressed. If you
>are not the intended recipient of this E-mail, you are hereby notified
>that any dissemination, distribution, copying, or action taken in
>relation to the contents of and attachments to this E-mail is strictly
>prohibited and may be unlawful. If you have received this E-mail in
>error, please notify the sender immediately and permanently delete the
>original and any copy of this E-mail and any printout.
>_______________________________________________
>Xymon mailing list
>Xymon at xymon.com
>http://lists.xymon.com/mailman/listinfo/xymon


This E-mail and any of its attachments may contain Time Warner Cable proprietary information, which is privileged, confidential, or subject to copyright belonging to Time Warner Cable. This E-mail is intended solely for the use of the individual or entity to which it is addressed. If you are not the intended recipient of this E-mail, you are hereby notified that any dissemination, distribution, copying, or action taken in relation to the contents of and attachments to this E-mail is strictly prohibited and may be unlawful. If you have received this E-mail in error, please notify the sender immediately and permanently delete the original and any copy of this E-mail and any printout.