[hobbit] split-ncv not working in Xymon 4.3.0-0.beta2

[Rich Smrcina]

I suspect it just got missed in the stack of emails.  Hopefully it will 
percolate to the top soon.

Bill Richardson wrote:
> I tried to use the split-ncv function in Xymon 4.3.0 beta2 and get the 
> following error in the rrd-status.log:
>  
> 2009-07-14 13:49:46 RRD error creating 
> /home/xymon/data/rrd/hostname/column,test.rrd: Duplicate DS name: lambda
>  
> I did a search on the mailing list and found Charles posting with a 
> patch for this dated back in Nov 2007. I made the change and 
> recompiled and it fixed the problem.
>  
> The change to be made is still at line 177 of the do_ncv.c
>  
> Change from  "if (split_ncv && (paridx > 1)) {"
> Change to  "if (split_ncv && (paridx > 0)) {"
>  
>  Does anyone know why the following changes didn't make it to the 
> current versions of Xymon?
>  
> Thanks
>  
> __________________________________________________________________________________________________________________________________________________________________________
>
>     * /To/: hobbit (at) hswn.dk
>     * /Subject/: [patch] off-by-one in do_ncv.c
>     * /From/: Charles Goyard <charles.goyard (at) orange-ftgroup.com>
>     * /Date/: Mon, 26 Nov 2007 16:37:38 +0100
>     * /User-agent/: Mutt/1.5.13 (2006-08-11)
>
> ------------------------------------------------------------------------
> Hi Henrik,
>
> I tried to update my hobbitd_rrd to the current snapshot version, and I
> got loads of "Duplicate DS name: lambda" when using split-ncv.
>
> I found the error lies here :
>
> --- do_ncv.c.old        2007-09-11 15:00:20.000000000 +0200
> +++ do_ncv.c    2007-11-26 16:36:43.000000000 +0100
> @@ -177,7 +177,7 @@
>                                 }
>                         }
>                         
> -                       if (split_ncv && (paridx > 1)) {
> +                       if (split_ncv && (paridx > 0)) {
>                                 create_and_update_rrd(hostname,
> testname, params, NULL);
>  
>                                 /* We've created one RRD, so reset the
>                                  * params for the next one */
>
> With this modification, it works.
>
> Thanks for your great software ! I hope 4.3 will be out soon !
>
> -- 
> Charles Goyard - charles.goyard (at) orange-ftgroup.com - (+33) 1 45 38 01 31
> Orange Business Services - online multimedia  // ingénierie


-- 
Rich Smrcina