[patch] off-by-one in do_ncv.c

Charles Goyard charles.goyard at orange-ftgroup.com
Mon Nov 26 16:37:38 CET 2007


Hi Henrik,

I tried to update my hobbitd_rrd to the current snapshot version, and I
got loads of "Duplicate DS name: lambda" when using split-ncv.

I found the error lies here :

--- do_ncv.c.old        2007-09-11 15:00:20.000000000 +0200
+++ do_ncv.c    2007-11-26 16:36:43.000000000 +0100
@@ -177,7 +177,7 @@
                                }
                        }
                        
-                       if (split_ncv && (paridx > 1)) {
+                       if (split_ncv && (paridx > 0)) {
                                create_and_update_rrd(hostname,
testname, params, NULL);
 
                                /* We've created one RRD, so reset the
                                 * params for the next one */

With this modification, it works.

Thanks for your great software ! I hope 4.3 will be out soon !

-- 
Charles Goyard - charles.goyard at orange-ftgroup.com - (+33) 1 45 38 01 31
Orange Business Services - online multimedia  // ingénierie



More information about the Xymon mailing list