[hobbit] Bogus status message contains no data (Re: [hobbit] SSL test flapping after latest snapshot)

[Henrik Stoerner]

On Thu, Jul 20, 2006 at 11:51:55AM -0700, Charles Jones wrote:
> Okay so I went through with my plan to wipe everything and reinstall.  
> Now I have a new problem. The statuses for the hobbit server itself, 
> specifically cpu, disk, files, memory. msgs, and procs have all turned 
> purple.
> 
> I'm seeing these errors in my hobbid.log:
> 2006-07-20 11:55:51 Bogus status message contains no data: Sent from hobbitd

I *think* these are caused by a test going purple, but it is odd that
these messages have no data.

Could you try applying this patch ? It won't change the behaviour, but
it will log the host- and test-name of the status that it complains
about.


Regards,
Henrik

-------------- next part --------------
--- hobbitd/hobbitd.c	2006/07/20 16:06:41	1.250
+++ hobbitd/hobbitd.c	2006/07/20 21:28:41
@@ -957,14 +957,15 @@
 	dbgprintf("->handle_status\n");
 
 	if (msg == NULL) {
-		errprintf("handle_status got a NULL message for %s.%s, sender %s\n", 
-			  textornull(hostname), textornull(testname), textornull(sender));
+		errprintf("handle_status got a NULL message for %s.%s, sender %s, color %s\n", 
+			  textornull(hostname), textornull(testname), textornull(sender), colorname(newcolor));
 		return;
 	}
 
 	msglen = strlen(msg);
 	if (msglen == 0) {
-		errprintf("Bogus status message contains no data: Sent from %s\n", sender);
+		errprintf("Bogus status message for %s.%s contains no data: Sent from %s\n", 
+			  textornull(hostname), textornull(testname), textornull(sender));
 		return;
 	}
 	if (msg_data(msg) == (char *)msg) {
@@ -2395,7 +2396,7 @@
 					/* Count individual status-messages also */
 					update_statistics(currmsg);
 
-					if (h && t && log && (color != -1) && (color != COL_PURPLE)) {
+					if (h && t && log && (color != -1)) {
 						handle_status(currmsg, sender, h->hostname, t->name, grouplist, log, color, downcause);
 					}
 				}