[hobbit] Display issues with SMTP and FTP status pages - 4.2RC20060712

Henrik Stoerner henrik at hswn.dk
Tue Aug 1 09:23:12 CEST 2006


On Mon, Jul 31, 2006 at 11:09:47PM -0700, Bob Gordon wrote:
> 
> I installed the 4.2RC20060712 system today and I am noticing some formatting
> issues with the status noted above the graph on the SMTP and FTP pages..
> Not sure if it affects other pages as well.
> 
> Mon Jul 31 22:52:14 2006 smtp ok
> 
> Service smtp on monitor is OK (up)
> 
> 
> 220  ESMTP..250-monitor Hello monitor [10.5.142.16], pleased to meet
> you..250-ENHANCEDSTATUSCODES..250-PIPELINING..250-8BITMIME..250-SIZE
> 83886080..250-DELIVERBY..250 HELP..250 2.1.0 monitor at monitor... Sender
> ok..221 2.0.0 monitor closing connection..

It is a bit over-zealous in weeding out binary data from the 
banner texts. This patch for the network tester should make it more
like it used to be.


Regards,
Henrik

-------------- next part --------------
--- bbnet/bbtest-net.c	2006/07/21 14:49:56	1.239
+++ bbnet/bbtest-net.c	2006/08/01 07:20:22
@@ -2318,7 +2318,7 @@
 
 					/* Binary data in banner ... */
 					for (i=0, p=STRBUF(t->banner); (i < STRBUFLEN(t->banner)); i++, p++) {
-						if (!isprint((int)*p)) *p = '.';
+						if (!isprint((int)*p) && !isspace((int)*p)) *p = '.';
 					}
 				}
 			}


More information about the Xymon mailing list