[hobbit] Termination errors in hobbit

[Henrik Stoerner]

On Fri, Sep 30, 2005 at 10:27:09AM -0500, Adam Scheblein wrote:
> Here is the gdb output:
> #7  0x080500cf in add_count (pname=0x0, head=0x8060838) at 
> client_config.c:571
> #8  0x0804a42e in unix_disk_report (hostname=0xb7dcb035 
> "optim.csd.mu.edu", hinfo=0x80615a0,
>    fromline=0x0, timestr=0x0, capahdr=0x8058289 "Capacity", 
> mnthdr=0x8058281 "Mounted",
>    dfstr=0xb7dcb14e "Filesystem          1024-blocks  Used  Available 
> Capacity Mounted on\n/dev/vg02/lvol1_snap") at hobbitd_client.c:308

OK, I think I've got it from this trace. Could you apply the
attached patch on top of the snapshot you have, and see if that
solves it ?


Regards,
Henrik

-------------- next part --------------
--- hobbitd/hobbitd_client.c	2005/09/28 21:21:56	1.34
+++ hobbitd/hobbitd_client.c	2005/09/30 15:53:55
@@ -314,7 +314,7 @@
 			if (usestr && isdigit((int)*usestr)) usage = atoi(usestr); else usage = -1;
 
 			strcpy(p, bol); fsname = getcolumn(p, mntcol);
-			add_disk_count(fsname);
+			if (fsname) add_disk_count(fsname);
 
 			if (fsname && (usage != -1)) {
 				get_disk_thresholds(hinfo, fsname, &warnlevel, &paniclevel);
--- hobbitd/client_config.c	2005/09/21 11:37:05	1.9
+++ hobbitd/client_config.c	2005/09/30 15:54:57
@@ -544,6 +544,8 @@
 	int ovector[10];
 	int result;
 
+	if (!pname) return;
+
 	for (pwalk = head; (pwalk); pwalk = pwalk->next) {
 		switch (pwalk->rule->ruletype) {
 		  case C_PROC: