<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2657.88">
<TITLE>RE: [hobbit] Channel processing problem with 4.11</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Confused even more now. Back to Sourceforge, from what I can tell, am using the current (?) release of hobbitserver 4.1.1. Not seeing anything in any of the Soureforge headings about a more current snapshot - under CVS or patch groupings.</FONT></P>
<P><FONT SIZE=2>For your supplied patch, patch failed to apply - inspecting the patch, there are the following reference to old and patched lines in the hobbitd_client.c:</FONT></P>
<P><FONT SIZE=2>- add_disk_count(fsname);</FONT>
<BR><FONT SIZE=2>+ if (fsname) add_disk_count(fsname);</FONT>
</P>
<P><FONT SIZE=2>Did a global search in the entire hobbit code tree and there is no add_disk_count function defined. Noticed the old code of:</FONT></P>
<P><FONT SIZE=2>if (fsname && (usage != -1)) {</FONT>
</P>
<P><FONT SIZE=2>Where in the 4.1.1 code base it is:</FONT>
</P>
<P><FONT SIZE=2>if (usage != -1)) {</FONT>
</P>
<P><FONT SIZE=2>Figured a check for valid fsname is what you are after before proceeding with the add_disk_count call above so made this change in the branch to work on disk threshold checking. Recompiled, retested, same error. Oh well.</FONT></P>
<P><FONT SIZE=2>For the second patch in client_config.c, the line counts do not add up in the patch - closest code appears to be in the add_process_count function. Would not expect add_process_count to be part of processing df messages. Guess the add_disk_count is defined in this module in another version.</FONT></P>
<P><FONT SIZE=2> </FONT>
</P>
<P><FONT SIZE=2>RCS string for hobbitd_client.c and client_config.c module in the 4.1.1 release are:</FONT>
<BR><FONT SIZE=2>static char rcsid[] = "$Id: hobbitd_client.c,v 1.21 2005/07/25 13:57:56 henrik Exp $";</FONT>
<BR><FONT SIZE=2>static char rcsid[] = "$Id: client_config.c,v 1.5 2005/07/24 07:50:13 henrik Exp $";</FONT>
</P>
<P><FONT SIZE=2>In the patch file, noticed string IDs for the patch targets of:</FONT>
<BR><FONT SIZE=2>--- hobbitd/hobbitd_client.c 2005/09/28 21:21:56 1.34</FONT>
<BR><FONT SIZE=2>+++ hobbitd/hobbitd_client.c 2005/09/30 15:53:55</FONT>
<BR><FONT SIZE=2>--- hobbitd/client_config.c 2005/09/21 11:37:05 1.9</FONT>
<BR><FONT SIZE=2>+++ hobbitd/client_config.c 2005/09/30 15:54:57</FONT>
</P>
<P><FONT SIZE=2>So looks like am working with an older release set. Using the CVS web browser agent on Sourceforge, not turning up any more recent code trees for other then the hobbit client package. </FONT></P>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: henrik@hswn.dk [<A HREF="mailto:henrik@hswn.dk">mailto:henrik@hswn.dk</A>]</FONT>
<BR><FONT SIZE=2>Sent: Friday, September 30, 2005 12:02 PM</FONT>
<BR><FONT SIZE=2>To: hobbit@hswn.dk</FONT>
<BR><FONT SIZE=2>Subject: Re: [hobbit] Channel processing problem with 4.11</FONT>
</P>
<BR>
<P><FONT SIZE=2>On Fri, Sep 30, 2005 at 10:47:39AM -0500, Deiss, Mark wrote:</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> I have narrowed down the fault in the client message to the first line in</FONT>
<BR><FONT SIZE=2>> the df output (how strange). Below is the client side code where only</FONT>
<BR><FONT SIZE=2>> reporting the initial client line and then the [df] block header and the df</FONT>
<BR><FONT SIZE=2>> output. If the HPUX df header line is removed before sending out message, no</FONT>
<BR><FONT SIZE=2>> error on channel. </FONT>
<BR><FONT SIZE=2>I just had another report about hobbitd_client crashing, also with the "df"</FONT>
<BR><FONT SIZE=2>reports. In that case I was able to track it down and the attached patch </FONT>
<BR><FONT SIZE=2>should fix it (the patch is on top of the current snapshot). Could you</FONT>
<BR><FONT SIZE=2>try if this fixes it ? It might be the same problem.</FONT>
<BR><FONT SIZE=2>Regards,</FONT>
<BR><FONT SIZE=2>Henrik</FONT>
</P>
</BODY>
</HTML>