[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [hobbit] bbtest-net crash: 4.2 RC with (fixed) all-in-one patch


On Aug 7, 2006, at 12:28 PM, Henrik Stoerner wrote:

On Mon, Aug 07, 2006 at 12:13:48PM -0400, John Payne wrote: 
I'm a new subscriber, been busy reading the archives.

First off... I don't think I saw this patch go through which fixes a
problem exposed by the all-in-one patch:

*** hobbitd/hobbitd_alert.c.old Fri Aug  4 17:55:04 2006
--- hobbitd/hobbitd_alert.c     Fri Aug  4 17:55:16 2006


I got this one just a few hours ago from another person, so it is
actually fixed already.

Ah... too slow! I was chasing down the 2nd bug that was biting me so as to only send one report :p

*** bbnet/bbtest-net.c.old      Mon Aug  7 12:06:27 2006
--- bbnet/bbtest-net.c  Mon Aug  7 12:07:28 2006
                /* parent */
!               char ip[IP_ADDR_STRLEN+1];

IP_ADDR_STRLEN is defined to be 16, but in start_ping_service, it's
being used:

sprintf(ip, "%s\n", ip_to_test(t->host));

Good catch! Applied. 

Excellent, thanks!