[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [hobbit] Re: Status not available
- To: hobbit (at) hswn.dk
- Subject: Re: [hobbit] Re: Status not available
- From: Henrik Stoerner <henrik (at) hswn.dk>
- Date: Tue, 1 Mar 2005 09:33:51 +0100
- References: <b537f65105022811186f3b60ea@mail.gmail.com> <b537f6510502281356281d4486@mail.gmail.com> <b537f651050228140017f56886@mail.gmail.com> <20050228221013.GF16768@hswn.dk> <b537f651050228141120a5773e@mail.gmail.com> <b537f651050228142669b80dc@mail.gmail.com> <20050228225918.GA22458@hswn.dk> <20050228230357.GA23259@hswn.dk> <b537f651050228151364a14fb1@mail.gmail.com> <20050301071343.GC9164@hswn.dk>
- User-agent: Mutt/1.5.5.1i
I've found something that might explain it, but I am certainly not
sure if it's the cause of your problems. This bug would only trigger
if some client of yours was sending in very large "data" messages,
like 100 KB or more.
Could you try the attached patch and let me know if it solves your
problem?
If not, I would like you to try and disable all of the hobbitd worker
modules in hobbitlaunch.cfg - i.e. bbstatus, bbhistory, bbdata,
bbnotes, bbenadies, bbpage, larrdstatus and larrddata. Restart hobbit
and see if it still crashes. If it doesn't then we've narrowed down
the problem - if it does, then the problem is somewhere else than
where I've been looking so far.
Thanks,
Henrik
--- hobbitd/hobbitd.c 2005/02/27 12:00:50 1.117
+++ hobbitd/hobbitd.c 2005/03/01 08:27:04
@@ -433,10 +433,11 @@
channel->msgcount++;
gettimeofday(&tstamp, &tz);
if (readymsg) {
- n = sprintf(channel->channelbuf,
+ n = snprintf(channel->channelbuf, (SHAREDBUFSZ-1),
"@@%s#%u|%d.%06d|%s|%s\n@@\n",
channelmarker, channel->seq, (int) tstamp.tv_sec, (int) tstamp.tv_usec, sender,
readymsg);
+ *(channel->channelbuf + n) = '\0';
}
else {
switch(channel->channelid) {